search

Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.8k stars 891 forks source link

Armor items from Create do not render trims when using Almost Unified or added via NBT data #6213

Open steve-the-player opened 5 months ago

steve-the-player commented 5 months ago

Describe the Bug

Base Create does not allow backtanks, diving helmets, or diving boots to be trimmed (https://github.com/Creators-of-Create/Create/issues/6204), but something in my modpack (possibly Almost Unified) allows them to be trimmed. You can also get the same results from editing NBT data. When they are trimmed, the visuals do not update to reflect that. I have tested this both on Forge and the Fabric port.

Reproduction Steps

  1. Install Create
  2. Install Almost Unified (or NBT editor)
  3. (optional) Install a mod/datapack like Create:Trimmed to allow for create materials to be used in trims (polished rose quartz, brass, zinc, xp)
  4. (optional) Install Better Trim Tooltips
  5. Trim a piece of Create armor (or paste the NBT data from trimmed vanilla armor)

Expected Result

armor should render decorative trims

Screenshots and Videos

2024-03-04_13 46 12 2024-03-04_13 46 33 2024-03-04_13 46 29 2024-03-04_13 46 25 2024-03-04_13 46 20

Crash Report or Log

No response

Operating System

tested on both MacOS (Ventura 13.5.1) and Windows 11

Mod Version

0.5.1d

Minecraft Version

1.20.1

Forge Version

latest. Fabric version was 0.15.6

Other Mods

I was using a dev/testing version of Delighted! when I first discovered the discrepancy, but that shouldn't be relevant

Additional Context

No response

DefomCode commented 3 months ago

will this mistake be solved at all? so much time has passed and there is not even an answer. I don't want my gaming experience to turn into a choice: to be stylish or to be completely protected and have an ugly appearance due to the fact that only trousers can visually improve

IThundxr commented 3 months ago

will this mistake be solved at all? so much time has passed and there is not even an answer. I don't want my gaming experience to turn into a choice: to be stylish or to be completely protected and have an ugly appearance due to the fact that only trousers can visually improve

there are over 1.3k open issues, all of which need to be looked at and triaged as necessary, please be patient, i'll get to this eventually