Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.93k stars 907 forks source link

Create Crash upon clicking new 'Create New World' #6636

Closed makefamilynotfriends closed 4 months ago

makefamilynotfriends commented 4 months ago

Describe the Bug

I have made a mod with MCreator that uses Create machines for recipes with some custom items and fluids. Using this with Create is causing a crash at the create new world screen (Screen name: net.minecraft.client.gui.screens.TitleScreen). Something is misaligned here, hopefully there is a simple resolution.

Reproduction Steps

  1. Click Single player
  2. Crash
  3. Cry

Expected Result

I expected to click Single player and load into the Create New World GUI screen.

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/RYbiBVB5

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Forge Version

47.3.0

Other Mods

Create: Refinery Create: Molten Metals Create Crafts & Additions Create : The Salt Create Sifting Create: Diesel Generators Just Enough Items (JEI) Moonlight Lib The Salt Tree Tap

Additional Context

Removing Create: Refinery stops the crash. Hoping a dev can help me narrow down what's causing this issue.

Suspected Mod: Create (create), Version: 0.5.1.f Issue tracker URL: https://github.com/Creators-of-Create/Create/issues at TRANSFORMER/create@0.5.1.f/com.simibubi.create.foundation.fluid.FluidIngredient$FluidStackIngredient.readInternal(FluidIngredient.java:182)

VoidLeech commented 4 months ago

Make sure your recipes with fluid inputs actually use fluids that exist (use conditions to check for mod/tag existence) and that you've made no typos. To use a fluid tag instead of a single fluid, use 'fluidTag' instead of 'fluid' in the fluid ingredient.

This would look to be Create Crafts & Additions otherwise, but the faulty recipe from createaddition-1.20.1-1.2.4c.jar should only be loaded when immersiveengineering is loaded.

makefamilynotfriends commented 4 months ago

Thanks for the response. May I ask, how did you locate this to be a Create Crafts & Additions faulty recipe? I'd like to know what to look for in future - and remove or alter this recipe if possible to avoid having to change mod version.

makefamilynotfriends commented 4 months ago

Create Crafts & Additions appears to be loading correctly. There were some recipes requiring fluids that are not added to the game - those have been fixed to the right fluids. However, none of the recipes added by Create: Refinery use fluids tags, though this seems to be the mod that's causing the crash.

VoidLeech commented 4 months ago

Crafts & Additions has been causing a lot of reports the past days in the discord, so that’s why this was recognizable. However, since the recipe in question shouldn’t be loaded, that shouldn’t have been the issue, and I wanted to point that out before the issue would be closed due to that.

Has correcting the fluid recipes fixed the crash? Make sure all fluids have an ‘amount’ field, and check recipe outputs as well for non-existing fluids (if you’ve made such recipes). In addition, make sure you have the right fluid name still, MCreator might’ve named it something like ‘{your-fluid-name-here}_fluid’. Backup your recipes, remove them, get into the game, press F3+H and look up your fluid in JEI to see the full id. (Or place it down and use F3’s ‘targeted fluid’; get the non-flowing version)

Ultimately this issue is not with Create though and should be closed accordingly.

makefamilynotfriends commented 4 months ago

Okay, thank you very kindly for your help. I think I have managed to locate the issue in my recipes based on what you've said. My apologies if this wasn't the right place for this issue. Best o/