Creators-of-Create / Create

[Forge Mod] Building Tools and Aesthetic Technology
MIT License
2.95k stars 910 forks source link

Minecart with chest transmutation, modded to vanilla #6986

Open Allmoz opened 2 months ago

Allmoz commented 2 months ago

Description

When using TFC mod "minecart with chest" in a "minecart with chest contraption", if the contraption is pickled up and placed down the minecart with chest get transmuted into a vanilla one, giving access to normally supposed to be unobtainable items such as the the vanilla chest in older versions, or the vanilla minecart with chest in the newer ones. It does not happen on chunk unload as for the other bug that hunts me (https://github.com/Creators-of-Create/Create/issues/5083), so i dont know if it could be a serialization issue. Tested on 0.5.1h on 1.18.2, i know that at least was an issue also in 0.5.1f, maybe earlier.

Placing TFC minecart with chest 2024-09-22_18 33 58

As a contraption it still is of the TFC kind 2024-09-22_18 34 08

If picked up 2024-09-22_18 34 12

and placed down, it turns into a vanilla one 2024-09-22_18 34 20

giving access to vanilla chest (minecart with chest if in hier versions) 2024-09-22_18 34 30

Game Log

https://mclo.gs/oyytxnx

Debug Information

Client Info ``` Create: Mod Version: 0.5.1h Forge Version: 40.2.9 Minecraft Version: 1.18.2 Graphics: Flywheel Version: 0.6.11-107 Flywheel Backend: INSTANCING OpenGL Renderer: Intel(R) HD Graphics 4400 OpenGL Version: 3.2.0 - Build 10.18.14.5162 Graphics Mode: options.graphics.fancy System Information: Operating System: Windows 7 (amd64) version 6.1 Java Version: 17.0.1, Microsoft JVM Flags: 10 total; -Xmx4096M -XX:MetaspaceSize=256M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M Memory: 2011014976 bytes (1917 MiB) / 4294967296 bytes (4096 MiB) up to 4294967296 bytes (4096 MiB) Total Memory: 11641225216 bytes (11097 MiB) / 12292861952 bytes (11718 MiB) CPU: Intel(R) Core(TM) i5-4210U CPU @ 1.70GHz @ 2.39 GHz; 2 cores / 4 threads on 1 socket(s) Graphics card #0: Intel(R) HD Graphics Family (Intel Corporation (0x8086)); 1024.00 MB of VRAM Graphics card #1: NVIDIA GeForce 820M (NVIDIA (0x10de)); 1024.00 MB of VRAM Other Mods: TerraFirmaCraft: 2.2.33 Patchouli: 1.18.2-71.1 ```
Server Info ``` Create: Mod Version: 0.5.1h Forge Version: 40.2.9 Minecraft Version: 1.18.2 System Information: Operating System: Windows 7 (amd64) version 6.1 Java Version: 17.0.1, Microsoft JVM Flags: 10 total; -Xmx4096M -XX:MetaspaceSize=256M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M Memory: 2011014976 bytes (1917 MiB) / 4294967296 bytes (4096 MiB) up to 4294967296 bytes (4096 MiB) Total Memory: 11641225216 bytes (11097 MiB) / 12292861952 bytes (11718 MiB) CPU: Intel(R) Core(TM) i5-4210U CPU @ 1.70GHz @ 2.39 GHz; 2 cores / 4 threads on 1 socket(s) Graphics card #0: Intel(R) HD Graphics Family (Intel Corporation (0x8086)); 1024.00 MB of VRAM Graphics card #1: NVIDIA GeForce 820M (NVIDIA (0x10de)); 1024.00 MB of VRAM Other Mods: TerraFirmaCraft: 2.2.33 Patchouli: 1.18.2-71.1 ```
Attack8 commented 1 month ago

The current logic just assumes that it’s a vanilla minecart chest, so you that would have to be stored somewhere in the contraption nbt, probably not that hard to do