Creatures-Developer-Network / prayer

prayer, a <WIP> Python Library for handling PRAY files
MIT License
2 stars 0 forks source link

Fix encodings used. #8

Open pushfoo opened 4 years ago

pushfoo commented 4 years ago

Encoding should be Windows-1252/CP-1252, not latin-1 according to themaltster.

KeyboardInterrupt commented 4 years ago

Good to know, I will look into this! I never encountered any issues with latin-1 though, do you have a Source for this?

KeyboardInterrupt commented 4 years ago

https://discordapp.com/channels/381123188224163841/698275219160432672/708689731944316968 found it

pushfoo commented 4 years ago

During work on #7 , @ligfx brought up the following question about python & encodings when I asked about edge cases for PRAY block names:

Can python do best fit mappings?

I'm leaving a note here because it appears to be out of scope for #7 and I don't understand ligatures or their encodings well enough at the moment to make sense of it.

pushfoo commented 4 years ago

Assuming we treat ligatures and other characters as something that should raise an exception, this should be easy. It can build off of work already present in the branch for #7.