Creckeryop / NOBORU

Application for PlayStation Vita to read manga or comics
GNU General Public License v3.0
167 stars 25 forks source link

[Feature Request] MangaDex authentication #28

Closed bb010g closed 4 years ago

bb010g commented 4 years ago

It'd be nice to use a MangaDex account to access search in-app (beyond ID lookups).

Tachiyomi handles this by sharing cookies with a browser session, but I'm not sure if you can yank cookies like that easily from the Vita's Browser.

Creckeryop commented 4 years ago

Tried to make it, Got cookies from browser, but they aren't fits to my app((( don't know why

Creckeryop commented 4 years ago

I think i found why that happens :DDDD

Creckeryop commented 4 years ago

In short, this feature works bad, here's possible reasons:

Creckeryop commented 4 years ago

You can make sure that browser have cookie problems by login to mangadex and update page to check login

bb010g commented 4 years ago

Could you store the auth cookies for sites like MangaDex locally in Noboru after import?

Creckeryop commented 4 years ago

cookies from MangaDex expires at the next day you saved it, so there is no sense in storing auth cookies for a long time

Creckeryop commented 4 years ago

Check this https://twitter.com/trash_cookie/status/1254459045748105218

bb010g commented 4 years ago

You didn't check "Remember me (1 year)"?

Creckeryop commented 4 years ago

Could you store the auth cookies for sites like MangaDex locally in Noboru after import?

So i should save my cookies for all users? or what do you mean

bb010g commented 4 years ago

Sorry, just gave the cookies branch code another read, and I think I get what's going on now. Disregard that comment. I'm assuming the code for general integration (or just MangaDex-specific, but generally reusing browser cookies on requests makes more sense to me) of cookies into search & other requests hasn't been publicly pushed yet?

I have to wonder if account support might help with rate limiting problems when downloading lots of chapters currently (without authentication).

Creckeryop commented 4 years ago

i can't understand what are tou speaking about

Creckeryop commented 4 years ago

i'll better close this request, because i already done this in 2fd900ae70b8e15f610b89c375ef74ec780d45f7