Allow sellers to accumulate purchase requests beyond positive credit limit

[tfwoodroofMCS]

Collated from description & comments on #103:

It should be possible for sellers to accumulate outstanding purchase requests even if approval of all of them would take their balance beyond its positive limit. In other words, buyers should not be blocked from making requests just because the seller has not yet approved or declined other buyers' requests. It may be that accumulation may have a separate limit, e.g. double the seller's positive limit.

At present, however, such requests are blocked at the buyer's end:

This is acceptable for the time being, but the desired behaviour should be implemented when time allows. Note that this can't be implemented with the current version of cc-node, which returns a positive limit violation error (max limit violation). In any case, it should probably be done in the front-end (perhaps via admin functionality?).

Once buyers are able to make such purchase requests, sellers will then have a choice of which to approve, at which point their positive limit should be enforced (i.e. approval of requests that would take the seller's balance beyond its positive limit should be blocked). This should already be working, but review the checklist in the main description of #103 to verify.

[dilgreen]

low priority, since neither current instance intends to set maximum balance limits, or is anywhere near the need to consider these.

Sent from Mailspring, the best free email app for work On Sep 21 2023, at 2:01 pm, tfwoodroofMCS @.***> wrote:

Collated from description & comments on #103:

It should be possible for sellers to accumulate outstanding purchase requests even if approval of all of them would take their balance beyond its positive limit. In other words, buyers should not be blocked from making requests just because the seller has not yet approved or declined other buyers' requests. It may be that accumulation may have a separate limit, e.g. double the seller's positive limit.

At present, however, such requests are blocked at the buyer's end:

[Image]

This is acceptable for the time being, but the desired behaviour should be implemented when time allows. Note that this can't be implemented with the current version of cc-node, which returns a positive limit violation error (max limit violation). In any case, it should probably be done in the front-end (perhaps via admin functionality?).

Once buyers are able to make such purchase requests, sellers will then have a choice of which to approve, at which point their positive limit should be enforced (i.e. approval of requests that would take the seller's balance beyond its positive limit should be blocked). This should already be working, but review the checklist in the main description of #103 to verify.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

[tfwoodroofMCS]

202 specifies messages and notifications assuming that sellers cannot accumulate purchase/transfer requests beyond their positive limit, i.e. that this has not been implemented.

However, as and when this is implemented, consider making its application optional/configurable, implying that the behaviours specified under the two 'balance plus outstanding' sections in #202 may remain relevant (if e.g. the 'double positive limit' suggestion in main issue body is adopted), and so should not be removed as redundant.