CredentialEngine / Schema-Development

Development of the vocabularies for the CTI models
14 stars 8 forks source link

Change QualificationFramework to QualificationsFramework (added s) #968

Closed philbarker closed 1 day ago

philbarker commented 2 days ago

Making sure we get the type name right.

siuc-nate commented 1 day ago

It's not something I feel terribly strongly about, but I would vote for keeping it singular for consistency with everything else in the schema, some of which (like condition profile) cover multiple things but are named in a singular way

philbarker commented 1 day ago

@siuc-nate I find the singular more natural, but every single example we have uses "Qualifications Framework", we have to go with such an established usage. As for consistency, the term as a whole is singular (a framework), if that helps.