search

Creditas / galeritas

Galeritas is an open library for data visualization.
Apache License 2.0
37 stars 3 forks source link

[Bug] plot_ks_classification - Redundant title and subtitle #16

Closed vivianyamassaki closed 2 years ago

vivianyamassaki commented 2 years ago

Describe the bug

The title and subtitle are generated based on plot_title parameter, making the information redundant.

Expected Results

Only one title would be necessary.

Actual Results

The title is appearing two times:

Screenshot from 2021-12-23 14-50-54

Steps/Code to Reproduce

from galeritas.plot_ks_classification import plot_ks_classification

titanic = pd.read_csv('../../tests/data/titanic.csv')

plot_ks_classification(titanic['predict_proba'], titanic['survived'], plot_title='Título repetido')

Your environment

Packages: galeritas: 0.1.3, matplotlib: 3.4.0, seaborn: 0.11.1 Python: 3.8 OS: Ubuntu 18.04.6 LTS

Any possible solutions?

We could remove the subtitle and maintain only the title.

Any other comments?

No response