search

Creditas / galeritas

Galeritas is an open library for data visualization.
Apache License 2.0
37 stars 3 forks source link

[Bug] plot_ks_classification - Rounded values for X axis when using min_max_scale parameter #17

Closed vivianyamassaki closed 2 years ago

vivianyamassaki commented 2 years ago

Describe the bug

When using the min_max_scale, there are some cases when the X axis values are rounded to 1.

Expected Results

The X axis ticks should shows the correct scaled values.

Actual Results

The values were rounded to 1:

Screenshot from 2021-12-23 19-41-22

Steps/Code to Reproduce

from galeritas.plot_ks_classification import plot_ks_classification

titanic = pd.read_csv('../../tests/data/titanic.csv')

plot_ks_classification(titanic['predict_proba'], titanic['survived'], min_max_scale = (0.8, 1))

Your environment

Packages: galeritas: 0.1.3, matplotlib: 3.4.0, seaborn: 0.11.1 Python: 3.8 OS: Ubuntu 18.04.6 LTS

Any possible solutions?

No response

Any other comments?

Maybe the parameter mix_max_scale name is confusing what the parameter was made for. The original and scaled values was intended to be printed?