search

CreeperHost / FTB-Backups-2

7 stars 8 forks source link

Orphaned backup files and skipped backups jobs #40

Closed ukmcplyr closed 1 year ago

ukmcplyr commented 1 year ago

Sunekaer's asked me to open as issue for bugs I've observed in FTB Backups shipped in Stoneblock 3.

In short there are two bugs:

  1. After a period, FTB Backups loses track of backup files stored in the top-level backups/. Starting over with a clean slate eventually leads to orphaned backups that are not listed in backups.json.

  2. During testing with backup_cron set to run every 3 minutes, backups are not consistently made even though a player is logged in.

See FTBTeam/FTB-Modpack-Issues#2189 for the more word-y report.

On the latter bug, I've left the server running with backup_cron set to 0 */3 * * * ? for a few hours with my player logged in and idling. Logs show 34 occurances of backups being skipped.

As noted in the FTB bug report, I've logs going quite far back but I'm unsure which would be most helpful.

ukmcplyr commented 1 year ago

I think I've hit another bug (NPE when stopping server seconds before backup job followed by short 2-3 minute hang). Stoneblock 1.4.2 as above. Unsure if I should tack it on here, create a new issue or route via FTB?

gigabit101 commented 1 year ago

I think I've hit another bug (NPE when stopping server seconds before backup job followed by short 2-3 minute hang). Stoneblock 1.4.2 as above. Unsure if I should tack it on here, create a new issue or route via FTB?

Logs?

ukmcplyr commented 1 year ago

latest.log

gigabit101 commented 1 year ago

The issue with player detection should be fixed in the next version, As for the skipping of removing backups this could be due to the last update or the zips can not be accessed due to permissions of the file already being open, If you remove these backups manually and the issue happens again let us know

ukmcplyr commented 1 year ago

nod I'll clear house again and report back if starts happening again. Cheers!

gigabit101 commented 1 year ago

The other issue should now also be fixed, Looks like a save was triggered as the server was shutting down causing a NPE

ukmcplyr commented 1 year ago

Different modpack (Direwolf20 1.19) but I'm seeing the same again. This time I have a better idea of when things went wrong and a possible cause. Soon after upgrading to a bad pack revision which had a fatal datapack error, orphans started appearing.

I've checked ownership and permissions on every path component leading up to backups.json and they're absolutely fine.

Are all bets off after a crash like I describe (FTBTeam/FTB-Modpack-Issues#2290) or...?

TIA.

gigabit101 commented 1 year ago

Fixed in latest release