search

CreeperHost / FTB-Backups-2

7 stars 8 forks source link

Server Hang when stopping #50

Closed TheLostInPlace closed 1 year ago

TheLostInPlace commented 1 year ago

9 or something similar seems to be happening again in 1.0.17. The last thing the server prints is "Shutting down map thread" and it just hangs.

Edit: Upon using Ctrl-C to end process, the console prints this https://i.imgur.com/gXzIr3w.png Edit2: This is using the Fabric version of FTBBackups.

gigabit101 commented 1 year ago

I have been unable to reproduce this issue, however, I have added a little more logging to help track down the issue in the next version.

JLBShecky commented 1 year ago

I can't grantee that this is the same issue as I am on Forge and not Fabric, but I ended up having my server crash while shutting down after I disabled automatic backups. It was a little hard to track down as although they were written to the console, the stack trace, and the additional logging message added in 1.0.17/1.0.18 were not written to the log files.

Stack trace from the console:

> java.lang.NullPointerException: Cannot invoke "net.creeperhost.ftbbackups.org.quartz.Scheduler.isShutdown()" because "net.creeperhost.ftbbackups.FTBBackups.scheduler" is null
        at TRANSFORMER/ftbbackups2@1.0.18/net.creeperhost.ftbbackups.FTBBackups.killOutThreads(FTBBackups.java:131)
        at TRANSFORMER/ftbbackups2@1.0.18/net.creeperhost.ftbbackups.FTBBackups.lambda$init$1(FTBBackups.java:46)
        at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
        at TRANSFORMER/architectury@6.5.69/dev.architectury.event.EventFactory.invokeMethod(EventFactory.java:53)
        at TRANSFORMER/architectury@6.5.69/dev.architectury.event.EventFactory$1.handleInvocation(EventFactory.java:62)
        at MC-BOOTSTRAP/com.google.common@31.0.1-jre/com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:89)
        at TRANSFORMER/jdk.proxy3/jdk.proxy3.$Proxy110.stateChanged(Unknown Source)
        at TRANSFORMER/architectury@6.5.69/dev.architectury.event.forge.EventHandlerImplCommon.event(EventHandlerImplCommon.java:95)
        at TRANSFORMER/architectury@6.5.69/dev.architectury.event.forge.__EventHandlerImplCommon_event_ServerStoppingEvent.invoke(.dynamic)
        at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73)
        at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315)
        at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296)
        at TRANSFORMER/forge@43.2.3/net.minecraftforge.server.ServerLifecycleHooks.handleServerStopping(ServerLifecycleHooks.java:116)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:664)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244)
        at java.base/java.lang.Thread.run(Thread.java:833)
gigabit101 commented 1 year ago

Should be fixed in latest versions

Simba98 commented 8 months ago

I would like to reopen it due to reproduce it on: Fabric 1.19.2 + ftbbackups2-fabric-1.19.2-1.0.23

[11:27:17 INFO] [Server thread]: [FTB Chunks] [dev.ftb.mods.ftbchunks.core.mixin.UtilMixin#handler$eeb000$ftbchunks$shutdownExecutorsFTBC] Shutting down map thread And stuck.

Gamerbolts commented 8 months ago

Hello,

This is also happening on fabric 1.20.1 v1.0.23, Every time I close the server it hangs and I have to kill it latest.log