CreeperHost / FTB-Backups-2

7 stars 9 forks source link

Automated Backups do not appear to be threadsafe #77

Closed tharwerth closed 7 months ago

tharwerth commented 9 months ago

Automated backups appear to be creating lockup conditions (either from a race condition or other file lock) and causing hard server crashes

https://pastebin.com/d2awuXyU

Pack: Direwolf20 1.20 Version: 1.0.1

brandon3055 commented 9 months ago

How often does this occur? Was it just once? Or is it a frequent occurrence?

Based on the log you provided, the server seems to be locking up during the world save. But the way we save the world should theoretically be identical to running the "/save-all flush" command. The only thing I can think of that may be an issue, is if the server is already in the process of saving.

tharwerth commented 9 months ago

It happens at almost every single world save (~ every 30 minutes)

On Sat, Oct 7, 2023, 10:25 PM brandon3055 @.***> wrote:

How often does this occur? Was it just once? Or is it a frequent occurrence?

Based on the log you provided, the server seems to be locking up during the world save. But the way we save the world should theoretically be identical to running the "/save-all flush" command. The only thing I can think of that may be an issue, is if the server is already in the process of saving.

— Reply to this email directly, view it on GitHub https://github.com/CreeperHost/FTB-Backups-2/issues/77#issuecomment-1751907031, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2TSUO373HLWYVYFYZPCHDX6IMKDAVCNFSM6AAAAAA5WGXFL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRHEYDOMBTGE . You are receiving this because you authored the thread.Message ID: @.***>

brandon3055 commented 9 months ago

Could you try manually running the "/save-all flush" command? That command should lock up the server until the save is complete, Though I can't imagine it taking long enough for the server to timeout.

ZombieSoul commented 8 months ago

This started happening to my recently installed Direwolf20 1.20 server. At first the server would just lock up for a few seconds every half hour. Which was irritating but we just waited it out. Now it crashes every time an automated backup tries to run. crash-2023-10-26_04.00.59-server.txt

brandon3055 commented 8 months ago

This issue should now be resolved with the release of version 1.0.23.

pucgenie commented 6 months ago

It's still happening - not everytime, but in 1 out of 4 cases. https://github.com/JDKDigital/productive-bees/issues/448 Even after removing productivebees mod, it still happened at about backup iteration number 28.