Creepercraft206 / CommandBinder

Recreation of CommandBinder from NeruxVace.de in 1.20.4
2 stars 0 forks source link

Commandbinder errors #1

Open lexarox opened 9 months ago

lexarox commented 9 months ago

If you add a command with /cb add some work but player commands dont really like if you add gamemode creative you wont be set to creative but weather clear or something like that works because I think you are using the console the execute the commands

When using /cb remove you cant use /cb remove * or all because of internal error or the feature is just not there yet i dont know

these were the issues i found but I would also recommend to:

use .equalsIgnoreCase() for commands

and I would try to get the already existing argument for the tabcompleter with something like this `

1 | ArrayList completions = new ArrayList<>(); -- | -- 2 | ArrayList subcommands 3 | if (args.length == 1) { 4 | subcommands.add("help"); 5 | subcommands.add("add"); 6 | subcommands.add("remove"); 7 | subcommands.add("insert"); 8 | subcommands.add("list"); 9 | subcommands.add("placeholders"); 10 | subcommands.add("info"); 11 | subcommands.add("customcommands"); 12 | subcommands.add("customcmds"); 13 | subcommands.add("ccmds"); 14 |   15 | StringUtil.copyPartialMatches(args[0], subcommands, completions); 16 |   17 | } 18 | return completions;

`

But the plugin is still pretty nice and I wanna thank you for remaking the plugin I really enjoyed neruxvace :D

Creepercraft206 commented 9 months ago

Hey, thank you very much for the suggestions and the feedback :) Im already aware of the fact that player specific commands aren't working right now, but im working on a solution, so that the commands are executed from the player. For now you can use the %player% placeholder for some commands like gamemode: /cb add gamemode creative %player%. The ability to remove all commands isn't implemented yet but will be added in an upcoming update, thx for the idea :) I will also look into your other suggestions if i can implement these somewhere👍