Add method for removing clients from server

CreggHancock / HolePuncher

UDP Holepunch plugin for Godot

MIT License

142 stars 34 forks source link

Add method for removing clients from server #6

Closed raffomania closed 3 years ago

raffomania commented 3 years ago

Without calling this method, clients wouldn't get cleaned up properly from the holepunch server if they cancel the nat traversal before it is complete.

CreggHancock commented 3 years ago

Ah yeah. That certainly fixes part of a hole, thank you. This could still have a problem since client checkout doesn't do anything to remove a session once the session becomes empty. I will probably get a solution for that. Also, the server should probably timeout old sessions after a certain time automatically in case the clients fail to send a checkout message.

Anyways, I'll merge this. Thanks again!

raffomania commented 3 years ago

Yes, those are good points as well!