Fix deserialization of nullable scalar fields

repli2dev commented 1 year ago

Description

Fix issue #15 when null values provided at deserialization are not properly injected into the properties

Motivation and context

Solves bug #15 .

How has this been tested?

Changed test cases to match current situation
Added new test cases
Manually

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

If someone relies on this not full documented issues it could be considered as BC.

Checklist:

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

repli2dev commented 1 year ago

@Crell thx for the review, I attempted to tackle all the issue.

Also I have created #20 as it would be nice to have code checks and reformats automated (I am unable to change the auto-imports per project as PHPStorm does not support that.)

repli2dev commented 1 year ago

@Crell I won't have much time in foreseeable future so feel free to close or rework this issue to your discretion.

Crell commented 1 year ago

Closing in favor of #25.

Crell / Serde