search

CrendKing / avisynth_filter

DirectShow filters that put AviSynth and VapourSynth into video playing
MIT License
107 stars 8 forks source link

Added remote control #3

Closed chainikdn closed 3 years ago

chainikdn commented 3 years ago

Probably there're some caveats here, but I'll need this anyway for the next step.

CrendKing commented 3 years ago

Can you explain a bit? What is this for? I thought we plan to change and reload script via some sort of IPC. I was thinking of either RPC for explicit semantic or message for simplicity.

chainikdn commented 3 years ago

Actually the RC will call ReloadAVSFile(). Right now it makes the "Reload" button work as expected when you click it.

Do you prefer one BIG commit or several smaller ones? :) In the latter case I could commit the whole "remote control" thing in a few minutes.

chainikdn commented 3 years ago

Here you are. Registry -> RemoteControl = 0/1. The RC API (messages IDs) are the same is in PotPlayer - so we can test it with the current SVP Manager version. The same is for "potplayer_source" and window class name. Since current SVP build passes not a script path but some script code, I also added an option to choose "Eval" instead of "Import" if _avsFile doesn't contain file path.

Obviously, this is not a final version at all, work in progress.

CrendKing commented 3 years ago

Do you prefer one BIG commit or several smaller ones? :)

It's always good if changes with isolate-able boundaries are broken into commits but you put the combined commits in one PR so I got the big picture. This way if something goes wrong, we can revert one of the smaller commits.

Speaking of which, I just pushed a big commit for supporting VFR, as discussed. Could you test it for me see if it's working as you intended, and if working rebase this PR on that?

chainikdn commented 3 years ago

Rebased in #4