search

CrendKing / avisynth_filter

DirectShow filters that put AviSynth and VapourSynth into video playing
MIT License
107 stars 8 forks source link

Doesn't pass HDR data w/o the script #33

Closed chainikdn closed 3 years ago

chainikdn commented 3 years ago
  1. disable SVP
  2. open a HDR video -> see BT.709 in madVR's OSD
  3. enable SVP -> madVR immediately switches to BT.2020
CrendKing commented 3 years ago

Does this fix? AviSynthFilter.zip

CrendKing commented 3 years ago

The version above is the bare minimum change. I took some time to further improve the pin connection logic. Please also verify if you have time.

AviSynthFilter.zip

chainikdn commented 3 years ago

--- fixed---

btw, are those /std:c++latest changes really necessary? this flag gives multiple errors in DirectShow headers, I can't build it anymore.

chainikdn commented 3 years ago

ups, sorry, my fault :D

Please also verify if you have time.

seems to work

CrendKing commented 3 years ago

OK. I was confused because I can't reproduce the crash.

/std:c++latest just allows C++20 features. I use a few of those, such as designated initializer and ranges. I think these features improve code quality and readability.

If you can't build, please do two things:

  1. Fresh checkout the repo, and run the build script: build.bat x64 (for x64 output) or build.bat x86 (for x86 output). If this works, then something is wrong with your Visual Studio, because the script directly invokes MSBuild. BTW, I also have automatic triggered build in this GitHub repo on every version release. I can manually trigger a build whenever needed. I don't see those builds fail since I switch to /std:c++latest.
  2. If the build script also fails with exactly the same message, then your VS2019 might be out of date. Update and if error persists, post the error messages in a new issue so I can take a look.

Since you confirmed working, I'm closing this issue.