CrendKing / avisynth_filter

DirectShow filters that put AviSynth and VapourSynth into video playing
MIT License
108 stars 8 forks source link

PotPlayer / EVR / 10-bit #75

Closed chainikdn closed 2 years ago

chainikdn commented 2 years ago

So I know EVR is not good in 10-bit playback... and still Daum PotPlayer allows it. If it's set to EVR (which is by default) and you play 10-bit video, everything is connected in P010 and looks good. The problem it's now NOT so good starting with AVSF 1.4.0. No SVP, no script, just an empty AVSF --> the video is totally unwatchable, like 1-2 fps. Any video - tried both 4K and 720p. Plays fine with AVSF 1.3.1.

chainikdn commented 2 years ago

When SVP is enabled (not even going 60, just doubling), the playback is already choppy.

In a real life user would adjust SVP settings so it run well on his computer. "Auto" settings in SVP should keep CPU load at ~70% max (considering the "baseline" is <10%, not 39% as in your test). And now we're replacing AVSF with the newer version which takes additional, lets say, 10% (this is what I saw when playing 4K at 60 fps on 4+HT config). And everything gets broken.

CrendKing commented 2 years ago

You are saying a system with 4 cores CPU (stop suddenly adding HT, you literally told me to disable HT earlier) + MPC + LAV + madVR can play 4K with < 10%. I just don't believe you. When I play 720p where the baseline is 10%, the bit shift adds < 1%.

If you are literally seeing this happening yourself, record a video and show me.

chainikdn commented 2 years ago

I just don't believe you.

mmm, what's the problem? with a hw video decoder active MPC-HC takes <5% (w/o AVSF)

stop suddenly adding HT, you literally told me to disable HT earlie

yeah, but I can't disable HT cause I'm on a laptop and msconfig.exe is my only choice

Overtone3 commented 2 years ago

lost

Hi, Sorry, just a quick update that:

  1. So I tried MPC-BE + madVR + LAV filter + SVP but still experiencing performance issues playing 4k 10bit HDR.
  2. Same issue if I uncheck P010 using ffdshow filters.
  3. I tried using DmitriRender as an alternative to SVP+AVSF, which works very smoothly actually using my GPU at ~90%. (I was able to generate 10bit output by changing the colorspacing options to P010 in PotPlayer.) When I enable madVR though, things go to shit (DmitriRender doesn't use AVSF).
  4. I know I originally had performance issues using SVP+EVR, apparetnly they prevail with madVR as well, but probably not due to system resources (since DmitriRender works great) but maybe AVISynth following recent update?
  5. CrendKing - sorry, I am not very familiar with the logging options. Would another AVISynth log help as proof? Do you need me to share a video of the playback?

Thanky you guys again so much for looking into this!!!

CrendKing commented 2 years ago

with a hw video decoder active MPC-HC takes <5% (w/o AVSF)

Your definition of "baseline" is without AVSF? OK. AVSF adds 10%. But how much of that is from bit shifting? Tell me how much AVSF adds 10-bit vs 16-bit. If it's 1%, don't tell me that 1% suddenly ruined your user's life.

chainikdn commented 2 years ago

Tell me how much AVSF adds 10-bit vs 16-bit.

I said - 10%. If it was 70% with smooth playback it's now 80% and choppy. That's the difference.

CrendKing commented 2 years ago

So I tried MPC-BE + madVR + LAV filter + SVP but still experiencing performance issues playing 4k 10bit HDR.

If you have problem with ffdshow + SVP, it might has nothing to do with AVSF.

I said - 10%. If it was 70% with smooth playback it's now 80% and choppy. That's the difference.

You are saying, in your laptop with 4+HT, without AVSF, it's using 5% playing 4K. Using old AVSF + SVP it reaches 70% and new AVSF + SVP it reaches 80%, right? What's the number without SVP? If you consistently seeing 10%, show me the log and screenshot/video please.

Overtone3 commented 2 years ago

Hi, I only used LAV because you wrote it is recomended. Without it I have color issues as well with MCE-BE. Buttom line is I am experiencing issues when using either SVP+AVSF+Any filter which I didn't have before ACSF recent update I think. Performance using DmitriRender (excluding madVR) is great, so I don't think this is a hardware issue. Cheers

chainikdn commented 2 years ago

base (no AVSF): 8% base (AVSF 16b): 13% base (AVSF 10b): 16%

SVP 60 fps, NVOF (10b->10b): 71% SVP 60 fps, NVOF (10b->16b): 66% SVP 60 fps, NVOF (16b->16b): 54%

SVP 80 fps, NVOF (16b): 78% SVP 80 fps, NVOF (10b): nogo, CPU 85%, SVP index <1

SVP 90 fps, NVOF (16b): nogo, SVP index <1

SVP 60 fps (16b): 68% (auto profile #8) SVP 60 fps (10b): 86%


60 fps: stable 15% difference between 10b and 16b 80 fps: not usable with 10b at all (see "single threaded load") 90 fps: not usable in any case, including full 8+8 cores config (see "single threaded load" again)


mpv plays 90 fps w/o issues with 75% CPU load

CrendKing commented 2 years ago

Overtone3: I'm genuinely confused. You said you have problem with PotPlayer, with LAV and with ffdshow. You said you have problem with EVR and madVR. You said you have problem with and without AVSF. You said you have problem with SVP. The only one without problem is DmitriRender.

Since I can't figure out how to reproduce the issue, I can't help. I suggest you to stay at the last working version for now, until you can gather new info.

chainikdn: For now, I suggest you either fork this project and do whatever you want, or disable 10-bit input format when your users install AVSF bundled with SVP.

If any of you have other concerns, please open a new issue. This one is too long to follow.