Some videos are broken with avisynth_filter

CrendKing / avisynth_filter

DirectShow filters that put AviSynth and VapourSynth into video playing

MIT License

108 stars 8 forks source link

Some videos are broken with avisynth_filter #77

Closed 0x4E69676874466F78 closed 2 years ago

0x4E69676874466F78 commented 2 years ago

When I activate Avisynth plus in potplayer as

i get this: https://media.discordapp.net/attachments/810211316794916925/997197258443473016/Harder_Neco_Faster_Arc..mp4

https://files.catbox.moe/zdtn9y.mp4

SVP version is also broken. But internal potplayer avisynth processing is ok.

CrendKing commented 2 years ago

Tested both videos and works fine here. Please upload some log.

0x4E69676874466F78 commented 2 years ago

@CrendKing avisynth_filter.zip avisynth_filter2.zip

0x4E69676874466F78 commented 2 years ago

I noticed that sometimes the video plays correctly. Could there be timing issues here? Another oddity, if the video was created through the windows gamebar and the game was in full screen mode, then such videos are guaranteed to be broken in avisynth_filter, but windowed games is ok.

0x4E69676874466F78 commented 2 years ago

In MPC-HC everything works fine. The problem is only on Potplayer.

0x4E69676874466F78 commented 2 years ago

More and more oddities. It seems to be related to DXVA and video resizing (if DXVA disabled then PrBoom video works fine, but not neco video) BUT! Right click on video -> Video -> Resize -> Do nothing = bug. Resize -> Resize always (or another modes) = works fine for all videos (even when DXVA enabled). Restart player required.

CrendKing commented 2 years ago

I can repro now, thanks to the log. It looks like you are not using LAV Filters to decode the video, but rather relying on PotPlayer's builtin filters. That somehow caused the problem. The reason why MPC-HC works is that it comes with LAV.

I mainly test the code with MPC and LAV, simply because they are open source. If you are not using the combination, expect to run into issues. Even if I want to support PotPlayer, they actively reject debugger to attach, and being closed source is not helping.

Since you can easily workaround by just using LAV in PotPlayer, I tend to close this as won't fix. OK?

0x4E69676874466F78 commented 2 years ago

@CrendKing yes LAV Filters with decoding (which includes FFDShow video decoder) works correctly. Thanks.

0x4E69676874466F78 commented 2 years ago

I think this issue is worth mentioning in the readme.

CrendKing commented 2 years ago

I think this issue is worth mentioning in the readme.

Sure. Do note that not all videos has the issue. Given you are the first person reporting this, it's probably rare.