search

CrendKing / mpv-twitch-chat

Show Twitch chat messages as subtitles when watching Twitch VOD with mpv.
MIT License
89 stars 4 forks source link

Add it mplug script directory #10

Closed z8512 closed 2 years ago

z8512 commented 2 years ago

Mplug is like a package manager but for mpv scripts. Please add your script there (if already not there) and also installation instructions in manifest - https://github.com/Nudin/mpv-script-directory/blob/master/HOWTO_ADD_INSTALL_INSTRUCTIONS.md

CrendKing commented 2 years ago

Thanks for letting me know. However, as I mentioned in #9, to avoid violating Twitch TOS, I'm not embedding the client ID for chat replay. Users of this script need to fill it in themselves. As I understand, the mplug mainly aims to automate the installation process, which can't be done for this script due to the client ID. So the only benefit I can see is maybe publicity, which I've already done by adding to https://github.com/mpv-player/mpv/wiki/User-Scripts.

z8512 commented 2 years ago

Hello and thank you. Add instructions in your readme how to install it using mplug. In post-installation instruction state to fill Client ID themselves after installing it using mplug

CrendKing commented 2 years ago

Like I said, I don't see the benefit. If user still has to create that option file, research the client ID and fill it in, the actual installation part of the script itself is rather easy in comparison. All needed is download and place the script in the right directory. If they don't know, for example what the "right directory" is, I highly doubt they know how to find the client ID and create option file by themselves.