search

Crendgrim / AutoHUD

A Minecraft mod for the Fabric launcher which dynamically hides parts of the user interface
GNU Lesser General Public License v3.0
16 stars 10 forks source link

Only Optifabric Compat Version (idea) #55

Closed IPECTER closed 1 year ago

IPECTER commented 1 year ago

but you may be able to add real compat code

Crendgrim commented 1 year ago

What am I meant to do this this unfinished code? Even looking at the code, it cannot be working correctly with OptiFabric installed. And I have zero interest in remaining compatibility with OptiFine; use Sodium + Iris instead.

No thank you.

IPECTER commented 1 year ago

@Crendgrim Uncommented code works really well, but I couldn't make code that was compatible with Optifabric and not-Optifabric at thr same time. So I wrote "IDEA" PR to listen your advice. I don't have your contact information, so there's no other way than PR...

Crendgrim commented 1 year ago

couldn't make code that was compatible with Optifabric and not-Optifabric at thr same time.

Right, so it is unmergeable in its current state, thus unfinished.

And, while I've once had a "patches welcome" mentality towards this: even if this was fully compatible with OptiFabric and non-OptiFabric at the same time, I would not want to merge it, because it would then fall onto me to keep this compatibility across future versions of the game (and even OptiFine). And with how horribly OptiFine breaks everything because they do not (have to) care about compatibility, that is not time I am willing to invest.

IPECTER commented 1 year ago

Okay, but it's only one mixin that has a problem and I think I'll find a solution that doesn't have a incompatible problem in future updates soon. I'll update the code when it's perfectly ready. Merge is your freedom. thank you very much for fast replying