search

Crendgrim / AutoHUD

A Minecraft mod for the Fabric launcher which dynamically hides parts of the user interface
GNU Lesser General Public License v3.0
16 stars 10 forks source link

backport to 1.18.2 #65

Closed CCr4ft3r closed 11 months ago

CCr4ft3r commented 11 months ago

I somehow missed the plan to backport it ... But now it's done and ready to release :)

You can create a new 1.18.2 branch based on the 1.19.2 one and change the target branch to it after reviewing the changes. However there are still some whitespaces but this time that's not an issue being caused by IntelliJ formatter since these weren't visible before pushing it. I think that's the diff viewer of GitHub itself. You can hide whitespace changes for the review: https://github.blog/2018-05-01-ignore-white-space-in-code-review/

CCr4ft3r commented 11 months ago

The feature hide whitespaces seems to be partly buggy on GitHub. However comparing it locally in IntelliJ can avoid the need of comparing blanks

Crendgrim commented 11 months ago

Thank you! I'll do some tests on the changes and then publish it, hopefully this weekend.

Crendgrim commented 11 months ago

Fabric version doesn't launch for me in dev environment, but seems to work when compiled and loaded. Probably some old toolchain issue. Quick tests seem to suggest everything works well, good job! Thanks for the backport.

Crendgrim commented 11 months ago

Published, and even managed to properly handle the GitHub side this time :tada:

CCr4ft3r commented 11 months ago

Fabric version doesn't launch for me in dev environment, but seems to work when compiled and loaded. Probably some old toolchain issue. Quick tests seem to suggest everything works well, good job! Thanks for the backport.

I also noticed that problem and then I tested it outside with all optional mods without problems. No problem :) It's a great mod.

Crendgrim commented 10 months ago

Weird behaviour: the compiled and released version doesn't work properly. It only moves the experience bar?

CCr4ft3r commented 10 months ago

In my tests the hotbar was being hided correctly after some seconds.

CCr4ft3r commented 10 months ago

Seems to be a strange problem with Forge versions prior to 40.2.4. On other versions, the HUD is being hided as expected. However, in all these versions all mixins could be applied without warnings or errors. So the best would be to define the forge version 40.2.4 as minimum in mods.toml.

CCr4ft3r commented 10 months ago

The user who reported the issue on CurseForge was using Forge 40.2.10. But with a clean setup it's working fine for me. Tested 40.2.9 and 40.2.10

Crendgrim commented 10 months ago

When I merged the PR, I tested it with 40.2.4 and it worked. I tested it with 40.2.4 today (new install) and it didn't work.

I am very confused.

Crendgrim commented 10 months ago

Okay, I officially am confused. Tested it again today to try figure it out, and it just... works. 😕

CCr4ft3r commented 10 months ago

🤣 For versions of 40.2.4 and above I tested it multiple times and it worked always fine. For 40.2.2 it failed immediately. So is 40.2.2 working fine for you?

I currently don't think that this is like a race condition of multiple mixins since no warnings or erros were logged in the debug.log when hiding of the HUD didn't worked.