search

Crendgrim / DynamicCrosshair

A Minecraft mod that hides or changes the crosshair dependent on context.
GNU Lesser General Public License v3.0
21 stars 6 forks source link

6.0+ cause Quilt Loader to crash #48

Closed AlfmanOO7 closed 1 year ago

AlfmanOO7 commented 1 year ago

Crash Report Log ^for version 6.2

Affected versions:

Bellabong commented 1 year ago

Exact same error on Fabric, but specifically the most recent version (5.6). The version before that (5.5) has a different start up error that I assumed was the reason for the same day upload and 5.4 has no issues.

Crendgrim commented 1 year ago

Hm, I am unable to replicate this on either Quilt or Fabric launcher. The error message doesn't tell me anything either.

Where exactly does this error happen, on startup?

AlfmanOO7 commented 1 year ago

Yes, the game doesn’t even launch, I have also let quilt know as the quilt launcher pops up and gives me an ‘invalid session’ error

Crendgrim commented 1 year ago

Weirdly, the error message points to the "take huge screenshot" method, which shouldn't have any relation to my mod at all, especially not during startup. If this is somehow caused by my mod, I must have messed things up something fierce..

Crendgrim commented 1 year ago

Ah, I managed to replicate it. The crash happens when both DynamicCrosshair and Memory Leak Fix are in the load order.

Crendgrim commented 1 year ago

Aha! I found it. DynamicCrosshair was using a newer version of the MixinExtras helper mod than Memory Leak Fix, and that had a bug. Which seemingly was already fixed upstream. I'm going to test a bit more and then push a version including the newer MixinExtras (or, if that fails, simply the same older version that MemoryLeakFix, and, presumably, other mods are shipping with).

Crendgrim commented 1 year ago

I pushed versions 5.6.1 (1.19.2) and 6.2.1 (1.19.4). Can you test whether that fixes all crashes? My limited testing seemed to suggest so, but there may be new crashes now with other mods.

AlfmanOO7 commented 1 year ago

All fixed! :D game loads fine, thank you!