[fabric 1.19.2] Exception occurred during evaluation of API bettercombat

[dadoirie]

https://mclo.gs/QMlGfRz

look like better combat or dynamic cross-hair changed something which broke their compatibility - hope this log shows whats wrong

confirmed with a instance only with those mods present:

[✔] bettercombat-fabric-1.7.1 1.19 [✔] cloth-config-8.2.88-fabric [✔] dynamiccrosshair-5.6.1 1.19.2-fabric [✔] dynamiccrosshair-compat-3.3.2 1.19.2 [✔] fabric-api-0.76.0 1.19.2 [✔] player-animation-lib-fabric-1.0.2

error/s (each error is for one zombie pointed at) at line 280 (https://mclo.gs/QMlGfRz#L280)

[Crendgrim]

Oof, that's a silly I did when trying to harden DynamicCrosshair against broken APIs, forgot about the one case where I actually use exceptions. I pushed DynamicCrosshair 5.6.2 which should fix this. Thanks for the report!

[dadoirie]

it's back on 1.20.1 (fabric)

[16:57:52] [Render thread/ERROR]: Exception occurred during evaluation of API bettercombat
mod.crend.dynamiccrosshair.api.CrosshairContextChange: null
    at mod.crend.dynamiccrosshair.compat.bettercombat.ApiImplBetterCombat.computeFromEntity(ApiImplBetterCombat.java:51) ~[dynamiccrosshair-compat-3.2+1.20.1.jar:?]
    at mod.crend.dynamiccrosshair.component.CrosshairHandler.buildCrosshairAdvancedByHand(CrosshairHandler.java:86) ~[dynamiccrosshair-7.0.2+1.20-fabric.jar:?]
    at mod.crend.dynamiccrosshair.component.CrosshairHandler.buildCrosshairAdvanced(CrosshairHandler.java:112) ~[dynamiccrosshair-7.0.2+1.20-fabric.jar:?]
    at mod.crend.dynamiccrosshair.component.CrosshairHandler.buildCrosshairDynamic(CrosshairHandler.java:199) ~[dynamiccrosshair-7.0.2+1.20-fabric.jar:?]
    at mod.crend.dynamiccrosshair.component.CrosshairHandler.buildCrosshair(CrosshairHandler.java:305) ~[dynamiccrosshair-7.0.2+1.20-fabric.jar:?]
    at mod.crend.dynamiccrosshair.component.CrosshairHandler.checkShowCrosshair(CrosshairHandler.java:345) ~[dynamiccrosshair-7.0.2+1.20-fabric.jar:?]
    at mod.crend.dynamiccrosshair.component.CrosshairHandler.tick(CrosshairHandler.java:366) ~[dynamiccrosshair-7.0.2+1.20-fabric.jar:?]
    at net.minecraft.client.gui.hud.InGameHud.handler$efp000$dynamiccrosshair$tickDynamicCrosshair(InGameHud.java:23405) ~[client-intermediary.jar:?]
    at net.minecraft.client.gui.hud.InGameHud.tick(InGameHud.java:1195) ~[client-intermediary.jar:?]
    at net.minecraft.client.gui.hud.InGameHud.tick(InGameHud.java:1159) ~[client-intermediary.jar:?]
    at net.minecraft.client.MinecraftClient.tick(MinecraftClient.java:1846) ~[client-intermediary.jar:?]
    at net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1181) ~[client-intermediary.jar:?]
    at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:802) ~[client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:250) ~[minecraft-1.20.1-client.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.21.jar:?]
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.21.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.21.jar:?]
    at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) ~[NewLaunch.jar:?]
    at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) ~[NewLaunch.jar:?]
    at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) ~[NewLaunch.jar:?]