search

CrestApps / laravel-code-generator

An efficient Laravel code generator, saving time by automating the creation of resources such as views, controllers, routes, migrations, languages, and form-requests. Highly flexible and customizable, it includes a cross-browser compatible template and client-side validation for application modernization.
https://laravel-code-generator.crestapps.com
MIT License
738 stars 158 forks source link

Title attribute is not convenient on mobile #46

Closed eduardoarandah closed 6 years ago

eduardoarandah commented 6 years ago

Environment:

Iphone 5s + safari

Description:

When title attribute is set on link buttons, you need to click twice on iphone to trigger the click, which is confusing.

I suggest removing it. I guess the title attr is good for SEO reasons in public pages, but this is not the case.

example: <a href="{{ route('[% create_route_name %]') }}" class="btn btn-success" title="[% create_model %]">

MikeAlhayek commented 6 years ago

What view are you referring to?

eduardoarandah commented 6 years ago

Well, I searched with sublimetext

title=".+"

and gave me these:

templates\default\create.blade.stub templates\default\edit.blade.stub templates\default\index.blade.stub templates\default\show.blade.stub templates\default-collective\create.blade.stub templates\default-collective\edit.blade.stub templates\default-collective\index.blade.stub templates\default-collective\show.blade.stub

I don't think title attribute has any significant value in todays web, only a tooltip, and there's better tooltips if that functionality is needed.

MikeAlhayek commented 6 years ago

The title may improve SEO for the app. I am unable to reproduce the issue your mentioning. I pulled up the demo on iPhone with safari and everything seems to be working as expected you can evaluate the demo on an iPhone https://www.crestapps.com/laravel-code-generator/demos/v2-2

eduardoarandah commented 6 years ago

you're right. I can't reproduce error in demo. I'll check on what conditions it gave me error.