Cretezy / redux-persist-expo-securestore

redux-persist storage for Expo's SecureStore
MIT License
74 stars 28 forks source link

Documented how to get Jest working. #7

Closed Asday closed 5 years ago

Asday commented 5 years ago

Jest doesn't transform code within node_modules/ by default, so any exported untranspiled code (such as this module) will cause it to fall over. This is not obvious to a beginner, and without explicit documentation, puts yet another barrier in the way to writing tests.

Cretezy commented 5 years ago

Do you want to create a PR with the documentation in the README? I've mostly moved on from using Expo, so would be a little hard for me to set it all up.

Asday commented 5 years ago

I did. This is the PR. :)

Cretezy commented 5 years ago

Oh man, how did I not notice that? :laughing:

It's still too early, didn't have my coffee yet. Thank you!

Cretezy commented 5 years ago

Sorry, thought you could merge when it was approved. I just merged it. Sorry for the delay!