Creuna-Oslo / create-react-app

React app boilerplate
MIT License
1 stars 1 forks source link

Fix build #50

Closed asbjornh closed 6 years ago

asbjornh commented 6 years ago

For some reason, the PR build went fine, but after merging master now refuses to build because of non-matching snapshot.

This PR attempts to fix this by replacing snapshot test with a proper test

asbjornh commented 6 years ago

So apparently this was caused by one test wrapping a function call with side effects inside of a t.notThrows assertion. This has been working fine up until now. Not sure why it suddenly failed.