CribberSix / pygame-texteditor

A complete WYSIWYG-texteditor built from scratch based on pygame for pygame.
MIT License
11 stars 5 forks source link

`pygame-ce` #15

Open brno32 opened 1 year ago

brno32 commented 1 year ago

Most of the pygame community is moving to https://github.com/pygame-community/pygame-ce

Will this library remain as an add-on to pygame or pygame-ce? And if someone wants to use this library with pygame-ce, what should their next course of action be?

CribberSix commented 1 year ago

Good question, I haven't been actively developing with PyGame for a while now. Might be worth seeing what would need to be changed to fit the new pygame-ce package. It might require a completely new texteditor package, depending on the differences of implementation between pygame andpygame-ce.

My guess is that pygame-ce will divert more and more in the future from pygame and thus might make it impossible to keep both as base for this package. Feel free to have a look! The best solution might be to create a pygame-ce-texteditor package (by copying the source code of pygame-texteditor and refactoring whatever necessary) to completly separate them from each other. This would also fix any issues with having conflicting dependencies and imports from both pygame and pygame-ce in the code... I am guessing they use basically the same namespace and conventions.

oddbookworm commented 1 year ago

I didn't see this until now, but as I am a member (and I suppose I'm one of the founders) of pygame-ce, I can speak on this topic a bit. You can't have both pygame and pygame-ce installed because they both install to the same pygame folder in your environment. The idea was that pygame-ce was intended to be a drop-in replacement for pygame. It's true that over time, we'll diverge from pygame, but the base functionality should remain the same. Backwards compatibility is important to us. Ideally, your source code would work with both unless you use something that's been added after the split (and even then, some pulls have been ported from pygame to pygame-ce). pygame hasn't really had any major updates, if you look at their releases, it's mostly small things and documentation translations. No real breaking changes for the vast majority of users

Edit: I realize now that it wasn't clear in my message. pygame-ce is a fork of pygame, so the source code is vastly the exact same

brno32 commented 1 year ago

Thanks for the insight! I guess I'm coming more from a dependency management standpoint.

For example, if you install this package (or some other pygame extension), it won't work with pygame-ce since pygame is a dependency of this project. Therefore, in your virtual environment, you'd have both pygame and pygame-ce installed.

There are lots of add-ons for pygame out there, and they should all be compatable in theory but I'm wondering what the work-around for the situation I laid out above is.