search

Cride5 / visualcube

A php script for generating Rubik's Cube visualisations
http://cube.crider.co.uk/visualcube.php
GNU Lesser General Public License v3.0
141 stars 40 forks source link

Port to Node.js? #13

Closed AviBueno closed 4 years ago

AviBueno commented 4 years ago

Hello Mr. Rider,

Thanks for a great repo. I'd like to ask if it's OK (or if there should be any issue) with me porting your code to Node.js as an alternative to forking your PHP code?

I'd like to also ask regarding the LGPL-3.0 license and the documentation in your webpage, but I'll wait for a reply first.

Hope to hear back from you.

Thanks.

Cride5 commented 4 years ago

Mr Bueno, yes porting to node.js is s good idea. Feel free to go ahead.

Best,

Conrad

On Sat, 18 Jul 2020, 02:56 Avi Bueno, notifications@github.com wrote:

Hello Mr. Rider,

Thanks for a great repo. I'd like to ask if it's OK (or if there should be any issue) with me porting your code to Node.js as an alternative to forking your PHP code?

I'd like to also ask regarding the LGPL-3.0 license and the documentation in your webpage, but I'll wait for a reply first.

Hope to hear back from you.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cride5/visualcube/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NUKYRSA2W5MLHQANE4OTR4CUGXANCNFSM4O6ZS7SQ .

AviBueno commented 4 years ago

Great news! Highly appreciated!

I'm no licence expert (nor even a novice). I though I'd consult you about relaxing the licence to MIT, but maybe I'll be best to leave things as they are.

One more thing: The request params documentation that appears on http://cube.rider.biz/visualcube.php is not part of the source code, so I hope you won't mind me copying it into the future repo's README.md file.

Please let me know if any of the above is an issue, or if I have you blessing :)

Thanks again.

Cride5 commented 4 years ago

The API page is in the file visualcube_api.php

The LGPL license should be fine for non-commercial applications. The 'lesser' version isn't viral (as in anything that uses the library doesn't need to be GPL).

Conrad

On 18/07/2020 19:53, Avi Bueno wrote:

Great news! Highly appreciated!

I'm no licence expert (nor even a novice). I though I'd consult you about relaxing the licence to MIT, but maybe I'll be best to leave things as they are.

One more thing: The request params documentation that appears on http://cube.rider.biz/visualcube.php is not part of the source code, so I hope you won't mind me copying it into the future repo's README.md file.

Please let me know if any of the above is an issue, or if I have you blessing :)

Thanks again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Cride5/visualcube/issues/13#issuecomment-660478992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NUK7LZWMQ7MR7KTUX5YLR4GLONANCNFSM4O6ZS7SQ.

-- Conrad Rider conrad@rider.biz http://rider.biz

Cride5 commented 4 years ago

The API page is in the file visualcube_api.php

The LGPL license should be fine for non-commercial applications. The 'lesser' version isn't viral (as in anything that uses the library doesn't need to be GPL).

Conrad

On 18/07/2020 19:53, Avi Bueno wrote:

Great news! Highly appreciated!

I'm no licence expert (nor even a novice). I though I'd consult you about relaxing the licence to MIT, but maybe I'll be best to leave things as they are.

One more thing: The request params documentation that appears on http://cube.rider.biz/visualcube.php is not part of the source code, so I hope you won't mind me copying it into the future repo's README.md file.

Please let me know if any of the above is an issue, or if I have you blessing :)

Thanks again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Cride5/visualcube/issues/13#issuecomment-660478992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NUK7LZWMQ7MR7KTUX5YLR4GLONANCNFSM4O6ZS7SQ.

-- Conrad Rider conrad@rider.biz http://rider.biz

AviBueno commented 4 years ago

Awesome! This issue can now be closed, but I suggest to leave it open so I could update once the port to Node.js will be released.

Thanks a bunch!

AviBueno commented 4 years ago

So... turns out that one of the forks of this very repo, is a complete rewrite in JavaScript: https://github.com/tdecker91/visualcube

Nothing more to see here folks.. closing the lid on this issue.

Thanks for your time @Cride5 .