search

CrimsonNynja / monster-hunter-DB

database for monster hunter
MIT License
39 stars 9 forks source link

Submitting again with some additions. #27

Closed priestkos closed 2 years ago

CrimsonNynja commented 2 years ago

Hi @priestkos Thanks for the PR! Sorry that I havn't been too active of late, been very busy lately.

Happy to merge this in, but would like a couple of changes first. I have been signifying that a quest is an event quest by having the questType set to Event. I would like to keep this consistent with the new quests you have added instead of adding a new flag. I would also like to remove the special field you have added, as there are plans to potentially add the drop tables or similar in the future which would cover this with that.

also for the id values, anything that is a valid unique UUID is fine to put in there. I tend to just increment the last ones by 1

Happy to make the changes on top of your branch, but also happy to let you finish them as well.

priestkos commented 2 years ago

alright @CrimsonNynja thanks for the reply! I am working on the new quests and will PR with the changes.

CrimsonNynja commented 2 years ago

closing, as all current quest are now in master