search

Crinsane / LaravelShoppingcart

A simple shopping cart implementation for Laravel
MIT License
3.67k stars 1.73k forks source link

Laravel 5.8 compatibility? #548

Closed lloricode closed 4 years ago

lloricode commented 5 years ago

@Crinsane

Crinsane commented 5 years ago

Feel free to send in a PR

aliqasemzadeh commented 5 years ago

@hardevine Please update to 5.8

lloricode commented 5 years ago

https://github.com/Crinsane/LaravelShoppingcart/pull/550 waiting to merge this

muhammetsait commented 5 years ago

Any news on this? @Crinsane

hardevine commented 5 years ago

@alighasemzadeh done

reina3596 commented 5 years ago

Up

VPetar commented 5 years ago

Meanwhile... https://packagist.org/packages/bumbummen99/shoppingcart Please merge #550 so we can all get back to this awesome package. ^_^

edsonrodsilva commented 5 years ago

Congratulations on the fabulous package, please merge this: https://github.com/Crinsane/LaravelShoppingcart/pull/550

jesseqli commented 5 years ago

Any updates on this?

VPetar commented 5 years ago

Any updates on this?

Don't think it's maintained anymore, you can use https://packagist.org/packages/bumbummen99/shoppingcart

Iconbanderas commented 5 years ago

Hi guys, I tried installing but it couldn't, I don't think there's compatibility for laravel5.8. any instructions?

Iconbanderas commented 5 years ago

image

edsonrodsilva commented 5 years ago

Hi, Use this even when we wait for a PR. https://github.com/bumbummen99/LaravelShoppingcart

Edson Rodrigues

Em seg, 5 de ago de 2019 às 12:16, Iconbanderas notifications@github.com escreveu:

[image: image] https://user-images.githubusercontent.com/32135282/62475112-4613e180-b79c-11e9-85fc-dbd1a6955666.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Crinsane/LaravelShoppingcart/issues/548?email_source=notifications&email_token=AAVW2DWCADSKT3EUIJTJEKDQDA73JA5CNFSM4G2P5QLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SENBI#issuecomment-518276741, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVW2DXBRHR4T4MBCOOYZXDQDA73JANCNFSM4G2P5QLA .

bumbummen99 commented 5 years ago

For learning purpose, if you encounter console output like that you should always check the 'requires' section in the composer.json file of the package you are trying to install. In the case of a laravel package it should state something like "illuminate/XYZ": "5.7.*" or even laravel/Laravel alongside other packages or versions. If that section does not include 5.8 the package will not be compatible with Laravel 5.8+. This will also be the same for 5.9.

Composer Versions and constraints Crisane/LaravelShoppingcart composer.json

bomshteyn commented 4 years ago

Hi, just wanted to let you know that we used to use this cart and ran into this issue as well so we have created our own open source version for Laravel v6. Please try it out https://github.com/treeStoneIT/shopping-cart

lloricode commented 4 years ago

its been a year

lloricode commented 4 years ago

this nothing works for now