search

Crinsane / LaravelShoppingcart

A simple shopping cart implementation for Laravel
MIT License
3.67k stars 1.73k forks source link

Added support for Laravel 5.8 #595

Closed jabarrioss closed 2 years ago

jabarrioss commented 4 years ago

I fixed a bug when firing events, from laravel 5.5 to fire an evento you should use the Event::dipatch() method instead of the Event::Fire() method

jabarrioss commented 4 years ago

Hey, please do not change the package name when you plan to create a PR. The proper way to handle this case would be to create an additional branch just for backporting/pr and keep the original package name there. Also do the tests still run properly?

I haven't run the test I changed the name of the package because I have to use for a project that I'm working on, and I needed to install it directly from my github

bumbummen99 commented 4 years ago

@jabarrioss That is absolutely fine, no worries! :) But this PR simply can not be merged with a different package name and you can not simply change it as your project depends on it. That is why i suggested creating the pr with a different branch that still has the original package-name but all the other changes.

rbergDrox commented 4 years ago

@jabarrioss @bumbummen99 here my PR #608
php version for laravel >=7.1.3 Logout event signature has changed I fixed by adding web guard I passed the tests