Crinsane / LaravelShoppingcart

A simple shopping cart implementation for Laravel
MIT License
3.67k stars 1.73k forks source link

the package unable to install on laravel 7 #611

Open shakhawatfci opened 4 years ago

shakhawatfci commented 4 years ago

Package Not installing on Laravel 7 can anyone help me ?

Mo7sin commented 4 years ago

It didn't even support laravel 6, So it's not maintained anymore I guess!

Faks commented 4 years ago

Hey, well yesterday, I spent about 3-4 hours to fork out all packages and bump versions up for Laravel dependencies and fix bugs on them to work with Laravel 6.0, I think it wouldn't be hard to add support to the Laravel 7.0 it is just time-consuming.

shakhawatfci commented 4 years ago

Ya i think so

On Fri, Mar 13, 2020 at 12:24 PM Jonh notifications@github.com wrote:

Hey, well yesterday, I spent about 3-4 hours to fork out all packages and bump versions up for Laravel dependencies and fix bugs on them to work with Laravel 6.0, I think it wouldn't be hard to add support to the Laravel 7.0 it is just time-consuming.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Crinsane/LaravelShoppingcart/issues/611#issuecomment-598570644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG3IHNBCO43FR3OCWGJ4J3RHHGSXANCNFSM4LFS5DDA .

bumbummen99 commented 4 years ago

There are maintained forks of this package, vanilla and extended.

https://github.com/Crinsane/LaravelShoppingcart/issues/593#issuecomment-551254784

futurewebsites commented 4 years ago

Hey, well yesterday, I spent about 3-4 hours to fork out all packages and bump versions up for Laravel dependencies and fix bugs on them to work with Laravel 6.0, I think it wouldn't be hard to add support to the Laravel 7.0 it is just time-consuming.

Hi How do I pull a version with Laravel 6 support?

shakhawatfci commented 4 years ago

Yes i used it but it’s not adding more then 2 product in cart :(

Is that my session setting problem ? bcz i upgrade laravel 6 project into 7 then I installed the package

On Sat, Mar 14, 2020 at 8:23 PM Patrick notifications@github.com wrote:

@futurewebsites https://github.com/futurewebsites They are "different packages" so you would use their composer package identifier to install them and continue with their Readme. But beware, some of those only provide compatibility updates and some also extend with new minor/major versions and break compatibility to the official documentation.

For a vanilla fork you would have to take a look at the pull requests and use one from there. There is also https://github.com/bumbummen99/LaravelShoppingcart but it is not compatible to this repos readme (while including all features and a lot of open PR's).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Crinsane/LaravelShoppingcart/issues/611#issuecomment-599068323, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG3IHMQOUUTP3DHOZIXMK3RHOHM3ANCNFSM4LFS5DDA .

Faks commented 4 years ago

Yes i used it but it’s not adding more then 2 product in cart :( Is that my session setting problem ? bcz i upgrade laravel 6 project into 7 then I installed the package On Sat, Mar 14, 2020 at 8:23 PM Patrick @.**> wrote: @futurewebsites https://github.com/futurewebsites They are "different packages" so you would use their composer package identifier to install them and continue with their Readme. But beware, some of those only provide compatibility updates and some also extend with new minor/major versions and break compatibility* to the official documentation. For a vanilla fork you would have to take a look at the pull requests and use one from there. There is also https://github.com/bumbummen99/LaravelShoppingcart but it is not compatible to this repos readme (while including all features and a lot of open PR's). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#611 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG3IHMQOUUTP3DHOZIXMK3RHOHM3ANCNFSM4LFS5DDA .

It was a bad idea to do such an idea since packages are very coupled, I have release merge/pull for laracom you can get it from my branch with laravel 6 it is working but should test a bit more for possible bugs.

shakhawatfci commented 4 years ago

When i build application from my pc the cart not adding more then 2product when I tried from my co workers pc it’s working but we are having same php version and setting 😿

On Tue, Mar 17, 2020 at 12:52 AM Jonh notifications@github.com wrote:

Yes i used it but it’s not adding more then 2 product in cart :( Is that my session setting problem ? bcz i upgrade laravel 6 project into 7 then I installed the package … <#m2315905793127135748> On Sat, Mar 14, 2020 at 8:23 PM Patrick @.**> wrote: @futurewebsites https://github.com/futurewebsites https://github.com/futurewebsites They are "different packages" so you would use their composer package identifier to install them and continue with their Readme. But beware, some of those only provide compatibility updates and some also extend with new minor/major versions and break compatibility* to the official documentation. For a vanilla fork you would have to take a look at the pull requests and use one from there. There is also https://github.com/bumbummen99/LaravelShoppingcart but it is not compatible to this repos readme (while including all features and a lot of open PR's). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#611 (comment) https://github.com/Crinsane/LaravelShoppingcart/issues/611#issuecomment-599068323>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG3IHMQOUUTP3DHOZIXMK3RHOHM3ANCNFSM4LFS5DDA .

It was a bad idea to do such an idea since packages are very coupled, I have release merge/pull for laracom you can get it from my branch with laravel 6 it is working but should test a bit more for possible bugs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Crinsane/LaravelShoppingcart/issues/611#issuecomment-599704558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEG3IHPHQU76VCQFQYVH4KDRHZYONANCNFSM4LFS5DDA .

olimortimer commented 4 years ago

I'm working on a fork that's compatible with Laravel 7 - everything seems to be working at the moment, but please submit a pull request if not;

https://github.com/olimortimer/LaravelShoppingcart

jonathan-bird commented 4 years ago

I've also created a fork, including various bugs that have been found in this repo such as the ability to now do GST per line item, which is needed in places like Australia. As well as new features like CartFee which is essentially shipping fee.

We are using this fork actively on a major ecommerce site so should always be stable.

https://github.com/digital-bird/LaravelShoppingcart/