Crio-Bytes / Database

Master repo regarding Database related MicroBytes.
MIT License
4 stars 6 forks source link

Basics of MySQL #15

Closed happycoder0011 closed 4 years ago

happycoder0011 commented 4 years ago

Kindly review.

sudhanshutiwari264 commented 4 years ago

@happycoder0011 Sorry for the delay, kindly edit your PR description and follow this template for the same in case of new MicroBytes. Also, your PR is under review.

Kevinpaulose05 commented 4 years ago

@happycoder0011 Pls work on my comments. We are eager to see ur completed contribution. U will get creator badges only if u do the needed latest by today midnight

happycoder0011 commented 4 years ago

@happycoder0011 Pls work on my comments. We are eager to see ur completed contribution. U will get creator badges only if u do the needed latest by today midnight

I have made the changes. Kindly, review.

YourAKShaw commented 4 years ago

@happycoder0011 Sorry for the delay, kindly edit your PR description and follow this template for the same in case of new MicroBytes. Also, your PR is under review.

Kindly do this ASAP!

Kevinpaulose05 commented 4 years ago

Adding to these, a couple more:

  1. In second terminal image of describe student command mention there is an alternative way as heading to diff the photos.
  2. Use proper formatting of bullets. Like after a heading like Insert values in table use bullets for the two subsequent cases. Do this for all such cases. Also, use a colon(:) after the heading separating it from its description.
  3. Before ur tasks mention the heading as a challenge, then sub-headings as tasks.
  4. Don't mention extra bytes, call it anything else like trivia/test urself/etc. What u r creating is a microbyte. Within that don't mention "bytes"
  5. Center align all tables

Kindly do these ASAP

Kevinpaulose05 commented 4 years ago

We have given you the label seeing the potential in ur PR and what we have achieved together. Kindly wrap-up ur microbyte with respect to our last comments. We are making an exception for you; u can complete this by maximum tomorrow night. After that we are sorry but we will have to close this PR which we don't want to since this is quality work. Kindly do the necessary ASAP and u can still get the creator badges and be considered for the other perks!

happycoder0011 commented 4 years ago

Adding to these, a couple more:

  1. In second terminal image of describe student command mention there is an alternative way as heading to diff the photos.
  2. Use proper formatting of bullets. Like after a heading like Insert values in table use bullets for the two subsequent cases. Do this for all such cases. Also, use a colon(:) after the heading separating it from its description.
  3. Before ur tasks mention the heading as a challenge, then sub-headings as tasks.
  4. Don't mention extra bytes, call it anything else like trivia/test urself/etc. What u r creating is a microbyte. Within that don't mention "bytes"
  5. Center align all tables

Kindly do these ASAP

I have made all the changes you noted. How to center the table?

happycoder0011 commented 4 years ago

Great work @happycoder0011 . Happy we could guide u. Another advocate will be shortly reviewing ur PR one last time and after their approval, we will merge it. Two things to do after merging only:

  1. Open as many learners issues as u can(within the scope of ur microbyte)
  2. Showcase ur newly merged microbyte in the #mirobyte-showcase channel in slack using this template

Also, fill this form right away.

Happy Contributing!!

Thanks a lot for your efforts, patience and guidance throughout the process.

happycoder0011 commented 4 years ago

Hey @happycoder0011! Thanks for working with us by making timely changes even after the challenge. I appreciate all the effort you have put in by adding tables, images etc.

This MicroByte can be used a "getting started" guide for needy learners. Also thanks for reverting the changes to CONTRIBUTING.md. It would make it hard to manage without that.

Cheers 😄

Thanks a lot!!

YourAKShaw commented 4 years ago

@all-contributors kindly add @happycoder0011 for:

allcontributors[bot] commented 4 years ago

@Ak-Shaw

I've put up a pull request to add @happycoder0011! :tada: