search

Crio-Bytes / Web

Master repo regarding Web related MicroBytes.
MIT License
9 stars 10 forks source link

[Microbyte] Building a responsive website layout using flexbox #6

Closed sandip2224 closed 4 years ago

sandip2224 commented 4 years ago

Added a MicroByte to involve the learners to make their own responsive website layout using CSS flexbox from scratch.

Checklist:

Fixes #7

Kevinpaulose05 commented 4 years ago

Pls don't open/close PRs unnecessarily. It is a bad practice to follow. Draft your microbyte and review it and keep pushing it. After a point when you are confident open a PR. Slight commits after PR opening is fine. But doing these many and ultimately closing it should be avoided. Kindly note this point.

sandip2224 commented 4 years ago

I'm sorry but I wasn't really familiar with the concept of raising issues and linking PRs and just got to know about it. Won't happen again.

sudhanshutiwari264 commented 4 years ago

@sandip2224 Kindly refer this to have a better idea about what we are looking for. Also follow the format for PR description as given in the template.

Furthermore, we need content that a learner can complete within 1-2 hours of learning time, provided they fulfill the prerequisites and it isn't just a TODO list. We need them to think, we need them to work on it by searching for answers on their own.

Your selected domain seems like it has much scope. Kindly try to segregate your current content and try to come up with a feasible structure for a great learning experience for any learner who comes across your MicroByte. Lastly, create an issue using requisite template provided for us to have a clear understanding on what you're working on. You can refer this for the same.

sudhanshutiwari264 commented 4 years ago

@sandip2224 You are doing great Btw !

sandip2224 commented 4 years ago

Hey @sandip2224! I liked the tasks you have given and the way you are painting a story around building the microbyte.

I think by providing the code at each activity end, it is kind of behaving like a spoon-fed approach, you can cut down that part and provide the final files at the end of the last activity (In this way, the learner when gets stuck will try to play around with properties and get his way through)

Also in some places you have specified exactly which element to add, for example: <div class="img">, rather you can make it as "Add a div with certain class" so it gives more experimenting based approach.

Also, you can cut down some of the initial instructions on how to create an HTML file & CSS file step by step.

Make these changes and we will review it ASAP :D

Done with the changes. Could you please review it?

Thank you

sandip2224 commented 4 years ago

@sandip2224 seeing your work, all that comes to my mind is that the content is rich, but, the activities are kinda misleading and aren't properly giving the LearnByDoing vibe. Like, where's the part where a learner try's to think on his own and makes his own choices and mistakes, which further aid him learning. Yours is not a tutorial, but seems like a tutorial type, where we have TODOs type of activities. The thing is that, if the learner already gets to know what to do by just reading it, he won't be learning, he'll just go through it, like some tasks.

So, coming to the point,

pros:

  • nice approach
  • rich content

cons:

  • activities aren't LearnByDoing types

By activities, I mean the documentation of the README.md. Kindly work on the README.md. You've already done this much work. All that's left is creating proper documentation, which shouldn't take much time.

Also, kindly follow the organization workflow, use the correct PR template for this PR in the description. Kindly refer this Crio-Bytes/Miscellaneous#1.

I hope I was able to give you directions to make improvements. Cheers. 🍻

I have made the requested changes and tried aligning the microbyte along LearnByDoing approach. Also I've made the required changes to the PR description. Could you please review it?

YourAKShaw commented 4 years ago

@sandip2224 nicely done. I see you got the correct direction after all. Kindly keep pushing yourself to bring in more content and we'll be happy to review it. Cheers :beers: