search

CrisisCleanup / crisiscleanup-1

[OLD] Legacy Crisis Cleanup on GAE/Python
https://sandy-disaster-recovery.appspot.com
Other
8 stars 4 forks source link

in main.js, site_ajax_handler is called one time too many #192

Open aarontitus opened 11 years ago

aarontitus commented 11 years ago

Original author: andy.n.g...@gmail.com (February 23, 2013 07:48:23)

In line 500 of main.js, change sites.length > 0, to sites.length < 100.

Right now, if there are 833 sites to be placed on the map, the code calls for sites in batches of 100, and keeps calling until 0 are returned.

This calls site_ajax_handler one too many times. The last call should be when there are less than 100 sites in the return, as specified above.

(I know this is an easy implement, I'll likely get it tomorrow, but I wanted to make sure we have a complete list of issues, so I don't have notes everywhere).

Original issue: http://code.google.com/p/sandy-disaster-recovery/issues/detail?id=192

aarontitus commented 11 years ago

From andy.n.g...@gmail.com on February 23, 2013 08:42:05 Implemented. Version 90 on sandy-helping-hands

aarontitus commented 11 years ago

From v...@aarontitus.net on February 25, 2013 02:23:08 I assume this was implemented. I have no easy way to test. If it's done and working, mark it "Fixed."

aarontitus commented 11 years ago

From andy.n.g...@gmail.com on February 25, 2013 02:24:30 It's implemented. I just added it up as a note to self when I was working on finding bugs.