CrisisCleanup / crisiscleanup-3-web

[OLD] Crisis Cleanup Version 3 Web Application based on Vue 2. This version was launched March 27, 2020 and retired March 10, 2023 when it was superseded by a Vue 3 version.
https://crisiscleanup.org
Apache License 2.0
19 stars 7 forks source link

Allow Address Edits/Change Address and Location #273

Closed aarontitus closed 4 years ago

aarontitus commented 4 years ago

Bug Because of the way the geocoder works, once an address has been entered, it is impossible to edit. Editing a single field at a time triggers a geocoding query that compares the new value against the other data, decides it is incorrect, and corrects it back to the original version.

To Reproduce Steps to reproduce the behavior:

  1. Go to Cases
  2. Click on any case. Click the edit button.
  3. Change one of the address fields
  4. Onblur, it will return to its original state

Second, related issue:

  1. Follow Steps 1-2 above.
  2. Try to manually move the pin on the map.
  3. You can't.
  4. Pressing the "Select on Map" button will change the What3Words value, but not the location on the map.

Expected behavior I don't know exactly what the solution is, but perhaps when editing, you could keep track of the edited fields, then compare the edited fields with the whatever the geocoding request returns, and only change the fields if the non-edited fields change. More clunky would be to turn off geocoding until you press another button. ...just some thoughts.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

aarontitus commented 4 years ago

This was solved by adding a trash can to clear the address and start over.