CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
4 stars 1 forks source link

Big fixes #1012

Closed tabiodun closed 3 months ago

tabiodun commented 3 months ago

fix: Add "Reset Phone System" button back on the Phone bug page. fix: Footer on Worksite needs to not overlap. fix: Increase number of chats to 50. Doesn't always scroll.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 11.76471% with 60 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (1af1919) to head (a16ef5c).

Files Patch % Lines
src/pages/dashboards/DashboardPage.vue 0.00% 26 Missing :warning:
src/components/phone/PhoneOverlay.vue 0.00% 23 Missing :warning:
src/services/phone.service.ts 53.84% 6 Missing :warning:
src/hooks/useConnectFirst.ts 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1012 +/- ## ========================================== - Coverage 21.93% 21.91% -0.02% ========================================== Files 375 375 Lines 80103 80152 +49 Branches 1296 1296 ========================================== + Hits 17567 17569 +2 - Misses 62536 62583 +47 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/1012/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/1012/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `21.91% <11.76%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Playwright test results

passed  51 passed
flaky  1 flaky

Details

stats  52 tests across 12 suites
duration  2 minutes, 20 seconds
commit  a16ef5c

Flaky tests firefox › pages/login.test.ts › LoginPage › should show error on login with invalid credentials - `( @slow @primary @development @staging @production )`