CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
6 stars 2 forks source link

Tobi develop #1019

Closed tabiodun closed 3 months ago

sentry-io[bot] commented 3 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/hooks/useDashboardActionItems.ts

Function Unhandled Issue
useDashboardActionItems TypeError: Cannot read properties of null (reading 'name_t') ...
Event Count: 1 Affected Users: 1
useDashboardActionItems TypeError: t is null nav.default_dashboard
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

github-actions[bot] commented 3 months ago

Playwright test results

passed  50 passed
flaky  2 flaky

Details

stats  52 tests across 12 suites
duration  1 minute, 49 seconds
commit  e505268

Flaky tests chromium › authentication.test.ts › Authentication › should redirect from login related unauthorized pages with existing session - `( @slow @primary @development @staging @production )` firefox › pages/login.test.ts › LoginPage › should login - `( @fast @primary @development @staging @production )`
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 1.35542% with 655 lines in your changes missing coverage. Please review.

Project coverage is 21.78%. Comparing base (98a31c8) to head (e505268).

Files Patch % Lines
src/components/Invite.vue 0.00% 111 Missing :warning:
src/pages/dashboards/DefaultDashboard.vue 0.00% 106 Missing :warning:
src/pages/dashboards/DashboardPage.vue 0.00% 85 Missing :warning:
src/hooks/useDashboardActionItems.ts 0.00% 81 Missing :warning:
src/hooks/useInviteUsers.ts 0.00% 67 Missing :warning:
src/pages/Work.vue 0.00% 54 Missing :warning:
src/components/user/UserList.vue 0.00% 50 Missing :warning:
src/components/modals/InviteUsers.vue 0.00% 38 Missing :warning:
src/utils/dashboard.ts 0.00% 12 Missing :warning:
src/pages/phone/PhoneSystem.vue 0.00% 7 Missing :warning:
... and 21 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1019 +/- ## ========================================== - Coverage 21.89% 21.78% -0.12% ========================================== Files 376 379 +3 Lines 80610 81034 +424 Branches 1304 1307 +3 ========================================== - Hits 17651 17650 -1 - Misses 62959 63384 +425 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/1019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `21.78% <1.35%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sentry-io[bot] commented 3 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎