CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
6 stars 2 forks source link

fix: Upgrade vue router & fix broken org users page after upgrade #1100

Closed deepanchal closed 1 month ago

deepanchal commented 1 month ago

Description

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

Checklist

Does this introduce a breaking change?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.81%. Comparing base (9065a0a) to head (1c22ee9). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/pages/organization/routes.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1100 +/- ## ======================================= Coverage 17.81% 17.81% ======================================= Files 410 410 Lines 64812 64812 Branches 1336 1336 ======================================= Hits 11544 11544 Misses 53268 53268 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/1100/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/1100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `17.81% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Playwright test results

passed  47 passed
flaky  3 flaky

Details

stats  50 tests across 11 suites
duration  8 minutes, 11 seconds
commit  1c22ee9

Flaky tests chromium-setup › auth.setup.ts › authenticate as admin - `( @primary @slow @read @development @staging @production )` firefox-setup › auth.setup.ts › authenticate as admin - `( @primary @slow @read @development @staging @production )` firefox-setup › auth.setup.ts › authenticate as user - `( @primary @slow @read @development @staging @production )`