CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
6 stars 2 forks source link

fix/top priority triston #903

Closed DatGamingStache closed 5 months ago

DatGamingStache commented 5 months ago

Description

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

Checklist

Does this introduce a breaking change?

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 55.50239% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 15.52%. Comparing base (df648e4) to head (fa8a914).

Files Patch % Lines
src/components/phone/PhoneOverlay.vue 0.00% 39 Missing :warning:
src/components/chat/Chat.vue 79.66% 24 Missing :warning:
src/components/work/CaseHeader.vue 0.00% 12 Missing :warning:
src/pages/Work.vue 0.00% 9 Missing :warning:
src/components/work/WorksiteSearchInput.vue 0.00% 4 Missing :warning:
src/App.vue 0.00% 3 Missing :warning:
src/components/Avatar.vue 95.45% 1 Missing :warning:
src/components/ImageModal.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #903 +/- ## ========================================== + Coverage 15.43% 15.52% +0.08% ========================================== Files 380 380 Lines 80631 80793 +162 Branches 841 847 +6 ========================================== + Hits 12444 12540 +96 - Misses 68187 68253 +66 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `15.52% <55.50%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Playwright test results

failed  4 failed
passed  45 passed
flaky  3 flaky

Details

stats  52 tests across 12 suites
duration  6 minutes, 39 seconds
commit  fa8a914

Failed tests chromium › pages/login.test.ts › LoginPage › should have data-testids - `( @fast @primary @read @development @staging @production )` firefox › pages/login.test.ts › LoginPage › should have data-testids - `( @fast @primary @read @development @staging @production )` chromium › pages/phone.test.ts › PhonePage › should have visible data-testids - `( @primary @slow @read @development @staging @production )` firefox › pages/phone.test.ts › PhonePage › should have visible data-testids - `( @primary @slow @read @development @staging @production )`
Flaky tests chromium-setup › auth.setup.ts › authenticate as user - `( @primary @slow @read @development @staging @production )` chromium-setup › auth.setup.ts › authenticate as admin - `( @primary @slow @read @development @staging @production )` firefox › pages/dashboard.test.ts › DashboardPage › should have data-testids - `( @fast @primary @read @development @staging @production )`