CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
4 stars 1 forks source link

feat: OTP Verification page, error handling improvements #904

Closed deepanchal closed 3 months ago

deepanchal commented 3 months ago

Description

Current Behavior

New Behavior

Screenshots

Related Issue

Refs #848

Pull Request Type

Please check the type of change your PR introduces:

Checklist

Does this introduce a breaking change?

sentry-io[bot] commented 3 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/hooks/useAuth.ts

Function Unhandled Issue
authStore ReferenceError: Can't find variable: t <anonymous...
Event Count: 3 Affected Users: 2
authStore SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. ...
Event Count: 1 Affected Users: 1
📄 File: src/utils/errors.ts (Click to Expand) | Function | Unhandled Issue | | :------- | :----- | | **`getErrorMessage`** | [**TypeError: Cannot read properties of undefined (reading '0')**](https://crisis-cleanup.sentry.io/issues/5402282812/?referrer=github-open-pr-bot) getErrorMessage(src/u...
`Event Count:` **1** `Affected Users:` **1** |

Did you find this useful? React with a 👍 or 👎

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 14.85944% with 212 lines in your changes are missing coverage. Please review.

Project coverage is 15.43%. Comparing base (4194b4f) to head (b68bd6b).

Files Patch % Lines
src/pages/unauthenticated/OtpLogin.vue 0.00% 124 Missing :warning:
src/utils/errors.ts 24.56% 43 Missing :warning:
src/hooks/useAuth.ts 37.70% 38 Missing :warning:
src/pages/unauthenticated/routes.ts 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #904 +/- ## ========================================== - Coverage 15.43% 15.43% -0.01% ========================================== Files 379 380 +1 Lines 80410 80631 +221 Branches 842 841 -1 ========================================== + Hits 12412 12444 +32 - Misses 67998 68187 +189 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/904/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `15.43% <14.85%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Playwright test results

failed  4 failed
passed  46 passed
flaky  2 flaky

Details

stats  52 tests across 12 suites
duration  3 minutes, 34 seconds
commit  b68bd6b

Failed tests chromium › pages/login.test.ts › LoginPage › should have data-testids - `( @fast @primary @read @development @staging @production )` firefox › pages/login.test.ts › LoginPage › should have data-testids - `( @fast @primary @read @development @staging @production )` chromium › pages/phone.test.ts › PhonePage › should have visible data-testids - `( @primary @slow @read @development @staging @production )` firefox › pages/phone.test.ts › PhonePage › should have visible data-testids - `( @primary @slow @read @development @staging @production )`
Flaky tests chromium-setup › auth.setup.ts › authenticate as admin - `( @primary @slow @read @development @staging @production )` chromium › pages/reports.test.ts › Reports › should have visible data-testids - `( @primary @slow @read @development @staging @production )`