E2e test fixes with new UI changes

deepanchal commented 5 months ago

Description

fix(comps): fix incorrect zoom tag in PhoneOverlay
fix(comps): set data-testids for all phone overlay sections in PhoneOverlay
test(e2e): add testNeedHelpCleaningUp data-testid for login data-testid test
test(e2e): add phoneOverlayActionTestIds for phone page data-testid test

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation changes

Checklist

[x] My code follows the code style of this project.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Does this introduce a breaking change?

[ ] Yes
[x] No

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 15.52%. Comparing base (742ac3f) to head (cb8b489).

Files	Patch %	Lines
src/components/phone/PhoneOverlay.vue	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #905 +/- ## ========================================== - Coverage 15.52% 15.52% -0.01% ========================================== Files 380 380 Lines 80793 80794 +1 Branches 847 847 ========================================== Hits 12540 12540 - Misses 68253 68254 +1 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/905/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/905/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `15.52% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.