Closed tabiodun closed 4 months ago
Your pull request is modifying functions with the following pre-existing issues:
š File: src/hooks/useAuth.ts
Function | Unhandled Issue |
---|---|
authStore |
ReferenceError: Can't find variable: t <anonymous... Event Count: 3 Affected Users: 2 |
authStore |
SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. ... Event Count: 1 Affected Users: 1 |
Did you find this useful? React with a š or š
Attention: Patch coverage is 12.85714%
with 61 lines
in your changes are missing coverage. Please review.
Project coverage is 15.52%. Comparing base (
95c5cdc
) to head (f16bdd0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ā 52 passed
Ā 52 tests across 12 suites
Ā 1 minute, 42 seconds
Ā f16bdd0
Summary Hooks: Refactor OTP generation and token exchange in useAuth.ts. Errors: Handle 409 conflict status in errors.ts. Phone System: Add conditional checks and save functionality in PhoneSystem.vue. Phone Overlay: Remove empty variant attribute in PhoneOverlay.vue. Worksite Form: Add error handling and return values in WorksiteForm.vue. Phone Outbound: Add Axios error handling in PhoneOutbound.ts. Admin Incident Wizard: Clean up incident data handling in AdminIncidentWizard.vue. Details src/hooks/useAuth.ts
Introduce CodeResponse interface. Rename functions for better clarity. Implement OAuth2 token exchange. src/utils/errors.ts
Add 409 status case to error handling. src/pages/phone/PhoneSystem.vue
Add null checks for worksiteForm. Introduce save option in confirmation dialog. Adjust success and error notifications. src/components/phone/PhoneOverlay.vue
Simplify closeTab button by removing empty variant attribute. src/components/work/WorksiteForm.vue
Ensure methods return false on errors to improve flow control. Add success return value in the save method. src/models/PhoneOutbound.ts
Enhance error handling with Axios error integration. src/pages/admin/AdminIncidentWizard.vue
Clean up incident data before saving. Remove unnecessary fields. This commit ensures improved error handling, better user interaction, and clearer function definitions, enhancing the overall code quality and reliability.