fix: OTP Login for multi accounts, e2e test fixes, pnpm v9 upgrade

deepanchal commented 4 months ago

Description

fix(comps): set $attrs on input field in BaseInput
fix(hooks): export verifyOtp, update loginWithOtp in useAuth
feat(pages): add selector for otp login w/ multiple accounts
fix(pages): use descriptive label for picking accounts on otp login
chore(deps): update pnpm to v9
Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation changes

Checklist

[x] My code follows the code style of this project.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Does this introduce a breaking change?

[ ] Yes
[x] No

sentry-io[bot] commented 4 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/hooks/useAuth.ts

Function	Unhandled Issue
`authStore`	ReferenceError: Can't find variable: t <anonymous... `Event Count:` 3 `Affected Users:` 2

_{Did you find this useful? React with a 👍 or 👎}

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 15.52%. Comparing base (4c98dda) to head (160401b). Report is 6 commits behind head on master.

:exclamation: Current head 160401b differs from pull request most recent head ea39ea9

Please upload reports for the commit ea39ea9 to get more accurate results.

Files	Patch %	Lines
src/pages/unauthenticated/OtpLogin.vue	0.00%	25 Missing :warning:
src/hooks/useAuth.ts	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #915 +/- ## ========================================== - Coverage 15.52% 15.52% -0.01% ========================================== Files 380 380 Lines 80881 80899 +18 Branches 848 848 ========================================== + Hits 12559 12561 +2 - Misses 68322 68338 +16 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/915/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/915/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `15.52% <10.34%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.