CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
4 stars 1 forks source link

feat: Eslint v9 #924

Closed deepanchal closed 2 months ago

deepanchal commented 2 months ago

Description

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

Checklist

Does this introduce a breaking change?

deepanchal commented 2 months ago

Waiting on this PR to be merged: https://github.com/import-js/eslint-plugin-import/pull/2873

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.52%. Comparing base (0984125) to head (61c2024).

Files Patch % Lines
src/components/Editor.vue 0.00% 2 Missing :warning:
src/main.ts 0.00% 2 Missing :warning:
src/components/live/D3BarChart.vue 0.00% 1 Missing :warning:
src/hooks/worksite/useRenderedMarkers.ts 0.00% 1 Missing :warning:
src/utils/downloads.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #924 +/- ## ======================================= Coverage 15.52% 15.52% ======================================= Files 380 380 Lines 80964 80970 +6 Branches 848 848 ======================================= + Hits 12567 12568 +1 - Misses 68397 68402 +5 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/924/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `15.52% <12.50%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Playwright test results

passed  48 passed
flaky  4 flaky

Details

stats  52 tests across 12 suites
duration  5 minutes, 5 seconds
commit  61c2024

Flaky tests chromium-setup › auth.setup.ts › authenticate as user - `( @primary @slow @read @development @staging @production )` firefox-setup › auth.setup.ts › authenticate as user - `( @primary @slow @read @development @staging @production )` chromium › pages/login.test.ts › LoginPage › should show error on login with invalid credentials - `( @slow @primary @development @staging @production )` firefox › pages/work.test.ts › WorkPage › should have visible data-testids - `( @primary @slow @read @development @staging @production )`