CrisisCleanup / crisiscleanup-4-web

Current Crisis Cleanup Web Application (Version 4) based on Vue 3. This version was launched March 10, 2023.
https://www.crisiscleanup.org/
Apache License 2.0
4 stars 1 forks source link

feat: Data Filter unit tests #944

Closed deepanchal closed 2 months ago

deepanchal commented 2 months ago

Description

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

Checklist

Does this introduce a breaking change?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 17.67%. Comparing base (c7b6589) to head (f71bdc1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #944 +/- ## ========================================== + Coverage 16.72% 17.67% +0.94% ========================================== Files 381 375 -6 Lines 81164 79941 -1223 Branches 1064 1227 +163 ========================================== + Hits 13572 14126 +554 + Misses 67592 65815 -1777 ``` | [Flag](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/944/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | Coverage Δ | | |---|---|---| | [unitTests](https://app.codecov.io/gh/CrisisCleanup/crisiscleanup-4-web/pull/944/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup) | `17.67% <100.00%> (+0.94%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CrisisCleanup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Playwright test results

passed  48 passed
flaky  4 flaky

Details

stats  52 tests across 12 suites
duration  3 minutes, 53 seconds
commit  f71bdc1

Flaky tests firefox-setup › auth.setup.ts › authenticate as admin - `( @primary @slow @read @development @staging @production )` firefox-setup › auth.setup.ts › authenticate as admin - `( @primary @slow @read @development @staging @production )` firefox › authentication.test.ts › Authentication › should load unauthorized routes as expected with and without authentication - `( @slow @primary @development @staging @production )` firefox › basic.test.ts › should have valid title & url - `( @fast @primary @read @development @staging @production )`