CrisisCleanup / crisiscleanup-android

Current Crisis Cleanup native Android
2 stars 0 forks source link

feat: Root Login screen ui (part 1) #72

Closed deepanchal closed 1 year ago

deepanchal commented 1 year ago

Description

Note: This screen isn't connected in UI. Its a standalone screen for now. Once all links are working, I will connect it in AuthenticateScreen

As per @arroyoDev, we should make the following changes for MVP:

If you wish to test it out locally, please apply the following patch

diff --git a/feature/authentication/src/main/java/com/crisiscleanup/feature/authentication/ui/AuthenticateScreen.kt b/feature/authentication/src/main/java/com/crisiscleanup/feature/authentication/ui/AuthenticateScreen.kt
index e0eae11b..bcdd7954 100644
--- a/feature/authentication/src/main/java/com/crisiscleanup/feature/authentication/ui/AuthenticateScreen.kt
+++ b/feature/authentication/src/main/java/com/crisiscleanup/feature/authentication/ui/AuthenticateScreen.kt
@@ -145,11 +145,17 @@ private fun AuthenticateScreen(
                             onCloseScreen,
                         )
                     } else {
-                        LoginScreen(
-                            authState,
-                            openForgotPassword = openForgotPassword,
-                            openEmailMagicLink = openEmailMagicLink,
-                            closeAuthentication = onCloseScreen,
+//                        LoginScreen(
+//                            authState,
+//                            openForgotPassword = openForgotPassword,
+//                            openEmailMagicLink = openEmailMagicLink,
+//                            closeAuthentication = onCloseScreen,
+//                        )
+                        RootLoginScreen(
+//                            authState,
+//                            openForgotPassword,
+//                            openEmailMagicLink,
+//                            closeAuthentication,
                         )

                         Spacer(modifier = Modifier.weight(1f))

Changelog

Screenshots

pr72.webm

Related Issue

Ref: #7

Pull Request Type

Please check the type of change your PR introduces:

Checklist

Does this introduce a breaking change?