fixed the issue that Popen.communicate hangs waiting stdout of a command

CrispyConductor / tmux-copy-toolkit

TMUX plugin with various copy-mode tools

MIT License

59 stars 6 forks source link

fixed the issue that Popen.communicate hangs waiting stdout of a command #6

Closed jaehyung-ca closed 3 years ago

jaehyung-ca commented 3 years ago

A way to work around issue #5 is to go without Popen.stdout. How do you think?

CrispyConductor commented 3 years ago

Interesting, I wonder why xclip doesn't just exit or close its output stream. But since stdout is ignored anyway, this looks like it's better code regardless, especially if it fixes the issue with this common use case. Thanks a lot for looking into this and for the PR, much appreciated!