search

Cristelknight999 / Expanded-Ecosphere

A realistic Minecraft worldgen mod.
32 stars 9 forks source link

I can confirm this does not work on Quilt. #30

Closed Sunconure11 closed 10 months ago

Sunconure11 commented 1 year ago

https://pastebin.com/nCXrqYkQ

Given the differences between the two aren't that huge, it shouldn't be that hard to make a port. @Cristelknight999

k2helix commented 1 year ago

Can confirm this also happens on 1.19.4 Same log

Cristelknight999 commented 1 year ago

Yes. This mod doesn’t support quilt. If you don’t need the config, use the datapack version, until I’ll make a quilt version someday

Abbie5 commented 1 year ago

hi, please stop mixing into fabric internals, fabric has a stable api for what you're doing. using the api will allow the mod to run on quilt, and will also prevent it from breaking on fabric api updates.

Cristelknight999 commented 1 year ago

Really? it has? please show me where

Cristelknight999 commented 1 year ago

and i don't think fabric will often change this. And i'll use cristel lib in future, which has quilt support.

Abbie5 commented 1 year ago

it's net.fabricmc.fabric.api.resource.ResourceManagerHelper#registerBuiltinResourcePack

Cristelknight999 commented 1 year ago

I know it exists. But then I can't disable packs on runtime. Or can I?